Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C curry-frontend
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 71
    • Issues 71
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • curry
  • curry-frontend
  • Merge requests
  • !56

Extract KnownTool type from Tool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fredrik Wieczerkowski requested to merge known-tool-type into master Jun 17, 2022
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 4

Similar to Extension, this branch splits

data Tool = KICS2 | PAKCS | CYMAKE | FRONTEND | UnknownTool String
  deriving (Eq, Read, Show)

up into

data KnownTool = KICS2 | PAKCS | CYMAKE | FRONTEND
  deriving (Eq, Read, Show, Enum, Bounded)

data Tool = KnownTool KnownTool | UnknownTool String
  deriving (Eq, Read, Show)

The surrounding helper functions are also updated, therefore this change should not have any impact on source or binary compatibility, everything should work exactly as before.

The primary motivation behind this change, in particular the deriving of Enum/Bounded instances, is to make it easier for the language server to query a list of known tools for code completion. Additionally it makes the definition slightly more consistent with the similarly defined Extension/KnownExtension types.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: known-tool-type